Skip to content

Use field names when serializing events to JS #848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 30, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion js/miso.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -2045,7 +2045,7 @@ describe('js tests', () => {
);

/* setup event delegation */
events = { click: ['click', true] };
events = [ { name : 'click', capture: true } ];
var getVTree = function (cb) {
cb(vtree);
};
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"test": "bun test js/miso.spec.js && bun run lcov",
"lcov": "lcov-viewer lcov -o ./coverage ./coverage/lcov.info",
"watch": "tsc ts/miso.ts --watch",
"pretty": "prettier --write ts/*.ts",
"pretty": "prettier --write ts/miso/*.ts ts/*.ts",
"build": "bun build --outfile=js/miso.js ./ts/index.ts --target=browser"
},
"type": "module",
Expand Down
23 changes: 21 additions & 2 deletions src/Miso/Delegate.hs
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
{-# LANGUAGE RecordWildCards #-}
-----------------------------------------------------------------------------
{-# LANGUAGE OverloadedStrings #-}
-----------------------------------------------------------------------------
Expand All @@ -17,10 +18,28 @@ module Miso.Delegate
import Control.Monad.IO.Class (liftIO)
import Data.IORef (IORef, readIORef)
import qualified Data.Map.Strict as M
import Language.Javascript.JSaddle (JSM, JSVal, Object(..), toJSVal)
import Language.Javascript.JSaddle (create, JSM, JSVal, Object(..), ToJSVal(toJSVal))
import Miso.FFI (delegateEvent, undelegateEvent)
import Miso.Html.Types (VTree(..))
import Miso.String (MisoString)
import qualified Miso.FFI as FFI
-----------------------------------------------------------------------------
-- | Local Event type, used to create field names for a delegated event
data Event
= Event
{ name :: MisoString
-- ^ Event name
, capture :: Bool
-- ^ Capture settings for event
} deriving (Show, Eq)
-----------------------------------------------------------------------------
-- | Instance used to initialize event delegation
instance ToJSVal Event where
toJSVal Event {..} = do
o <- create
flip (FFI.set "name") o =<< toJSVal name
flip (FFI.set "capture") o =<< toJSVal capture
toJSVal o
-----------------------------------------------------------------------------
-- | Entry point for event delegation
delegator
Expand All @@ -30,7 +49,7 @@ delegator
-> Bool
-> JSM ()
delegator mountPointElement vtreeRef es debug = do
evts <- toJSVal (M.toList es)
evts <- toJSVal (uncurry Event <$> M.toList es)
delegateEvent mountPointElement evts debug $ do
VTree (Object vtree) <- liftIO (readIORef vtreeRef)
pure vtree
Expand Down
8 changes: 4 additions & 4 deletions ts/miso/event.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,11 @@ export function delegate(
) {
for (var event in events) {
mount.addEventListener(
events[event][0],
events[event]['name'],
function (e: any) {
listener(e, mount, getVTree, debug);
},
events[event][1],
events[event]['capture'],
);
}
}
Expand All @@ -32,11 +32,11 @@ export function undelegate(
) {
for (var event in events) {
mount.removeEventListener(
events[event][0],
events[event]['name'],
function (e: any) {
listener(e, mount, getVTree, debug);
},
events[event][1],
events[event]['capture'],
);
}
}
Expand Down