-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Language Fallback for non-ascii languages #153
base: development
Are you sure you want to change the base?
Conversation
Merge hotfix/2.0.14
If I'm logged in into the backend, it works else not ... |
The plan is to bring back |
@dmitryd What do you mean by "the request is not clean"? |
This should indeed not happen, I think this is due to a local conflict. I'll try to fix this now and make another pull request. |
This looks better now, what do you think? |
No, it doesn't :( I think you work with old sources. Please, see how Please, update your copy before making a pull request to use latest file versions. |
Ok, now I get what I got wrong, I thought I'd revmoed them by mistake but you took care of this (sorry for the burden). So ext_localconf.php is now in the newest version, so no conflict possible there now. |
I'll do some more work on this later because there are other places where this has to be implemented. |
You could also improve the You could either use the utf8_romanize method from dokuwiki: https://github.com/splitbrain/dokuwiki/blob/master/inc/utf8.php Or you could use the Transliterator class from PHP (if it exists): if (class_exists('Transliterator')) {
$translit = \Transliterator::create('Any-Lower; Any-Latin; Latin-ASCII;');
$processedTitle = $translit->transliterate($processedTitle);
}
|
@rvock This should be a separate pull request and it should be carefully evaluated because it may break compatibility. |
@CDRO Imagine for example a site where German is the default language, English the 2nd language and Japanese the 3rd language. If you set |
@mbrodala I think you're right, this feature would be really great to have in this kind of situation. I'll have a look at the current source code and propose a new MR in some weeks in order to cover this scenario. |
@rvock I think we do not need a transliterator that translate asian letters. As far as I see, people prefer to have them in urls. |
When using japanese or chinese (or any non-ascii supporting language), realurl will simply encode the page names to the request query.
This is quite annoying, since this will never work (this is known since some years now). There used to be an option called languageExceptionUids, but it doesn't exist anymore, so I built it again.
What has to be done to work properly is that you have to add this to the pagePath Configuration part: