Preserve timezone=False for naive Arrow timestamps#4016
Open
dbascoules wants to merge 1 commit into
Open
Conversation
Collaborator
|
what you say looks right! this behavior is thoroughly tested - I need to see why some of the tests had failed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a regression where DLT dropped the explicit timezone=False hint inferred from naive Arrow timestamps during capabilities adjustment.
Previously, Arrow input with naive timestamps was normalized as if the timezone hint were absent, which caused downstream loading to convert values to UTC-aware timestamps instead of keeping them naive. This affected pass-through behavior for sources that already expose naive Arrow timestamps, including ConnectorX-based extraction.
The fix preserves timezone=False when it is explicitly present on a column, while continuing to strip other timezone values so the default behavior remains unchanged where no explicit hint is set.
Related Issues
Additional Context