Fix logging more frequent than log_period#3962
Open
cbility wants to merge 1 commit into
Open
Conversation
…the log collector This line causes a log to be emitted every time a line is added to the log message, which can result in far more frequent logs than the max specified by log_period
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove line that resets
last_log_timewhenever a counter is added to the log collector.This line causes a log to be emitted every time a line is added to the log message, which can result in far more frequent logs than the max specified by
log_period.Description
Related Issues
log_periodargument indlt.progress.logseems to have no effect in version 1.9 #2532Additional Context
Tested in my dlt project and it fixes the logging issue. Logs are emitted at the specified frequency, except for when changing stages e.g. extract to load, when they can be more frequent.