-
-
Notifications
You must be signed in to change notification settings - Fork 651
Replace Identifiers* names
with ArgumentLabels* names
across the frontend
#21297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This shouldn't be targeting stable unless it's a bug fix. Thanks. |
Apologies for the confusion caused. I forgot to mention this is a continuation of PR #21262, in that PR I added a new Now to answer the questions:
I hope this clarifies everything. I split the changes into 2 PRs as I thought it would be confusing and people might think... why all the
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR's diff does 2 things:
- rename
names
toargLabels
- fix the bug where argLabels don't get expanded with tuples
Mixing refactoring and bug fixes in a single pull requests should generally be avoided, because when a regression happens and a bissection points to this PR, it is still hard to see what's going on because actual code changes are mixed with many lines that simply rename something. Can you simplify this PR by applying the code changes to the original names
variable?
a964f5d
to
1544118
Compare
Identifiers* names
with ArgumentLabels* names
across the frontend
7a1d315
to
e985ea1
Compare
This PR is a continuation of PR #21262. Check it out for more details.
#Summary
This PR replaces all uses of the
Identifiers* names
field in expression-related functions (callExp
,newExp
, etc.) with a more expressive and structured alternative:ArgumentLabels* argLabels
.names
fields (of typeIdentifiers*
) withargLabels
(of typeArgumentLabels* = Array!(ArgumentLabel)
).argLabels
is backwards-compatible where necessary by providingIdentifiers*
via helper conversion.