-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add JavaScript solution to Bank OCR Kata #1
Open
dkubb
wants to merge
25
commits into
main
Choose a base branch
from
add/javascript-solution
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add eslint configuration
* Add yarn lint:watch command to run eslint on each file change.
* Add jasmine configuration * Add stub BankAccount test so CI passes with jasmine * Add yarn test command * Add yarn test:watch command
dkubb
force-pushed
the
add/javascript-solution
branch
4 times, most recently
from
July 28, 2020 15:53
56f8c63
to
6f910f9
Compare
* Add BankAccount.matchDigit private static method
* This mapping allows for small errors to be corrected and mapped to the correct digit.
dkubb
force-pushed
the
add/javascript-solution
branch
4 times, most recently
from
August 4, 2020 18:19
08bdded
to
12044e2
Compare
dkubb
force-pushed
the
add/javascript-solution
branch
3 times, most recently
from
August 6, 2020 19:43
ab568c6
to
622ff36
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch adds a JavaScript solution to the Bank OCR Kata outlined in the README.
Each commit should pass with CI, and should be the smallest atomic (useful) commit I could make to the repo to satisfy the requirements.