Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

small changes to solve some small issues #83

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

joancf
Copy link

@joancf joancf commented Dec 7, 2017

no begin/end in wsdresult
crash when no POS (This happens in multiwords) for WSDAnnotatorContextPOS
-The current option is to set up NOUN as default POS

  • the other one is to generate an exception with a clear message
  • another option is to create a method that does the same as WSDAnnotatorContextBase (with no pos) and call it when pos is not available.

no begin/end in wsdresult
crach when no POS (This happens in multiwords)
@reckart
Copy link
Member

reckart commented Dec 16, 2017

Jenkins, can you test this please?

@ukp-svc-jenkins
Copy link

Can one of the admins verify this patch?

@logological
Copy link
Member

@joancf, if you are still interested in contributing, could you please split this into separate pull requests for each of the unrelated issues you are fixing? The begin/end fix is fine but some work/discussion is needed for the exception handling issue.

@joancf
Copy link
Author

joancf commented Sep 7, 2021

That's 4 years old, I'm sorry, I'm not using UIMA right now. I have change computer, I don't have the project .
But I think the changes are simple, ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants