Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2 Add Flags for Aggregation and Verbosity #9

Merged
merged 7 commits into from
Jul 11, 2024

Conversation

djokester
Copy link
Owner

@djokester djokester commented Jul 11, 2024

  1. Added test case for attempting to load base_metric through evaluator
  2. Added argument for aggregation function for score and their test cases.
  3. Added argument verbose to enable logging of the decomposition of text and subsequent scoring breakdown
  4. Moved the score function to the base_class to reduce repetitions
  5. Updated badges in the readme as well as some non-performant sections.
  6. Updated README.md to reflect the changes made to verbosity and aggregation.

@djokester djokester self-assigned this Jul 11, 2024
@djokester djokester linked an issue Jul 11, 2024 that may be closed by this pull request
4 tasks
@codecov-commenter
Copy link

codecov-commenter commented Jul 11, 2024

Codecov Report

Attention: Patch coverage is 96.93878% with 3 lines in your changes missing coverage. Please review.

Project coverage is 98.78%. Comparing base (9b92ca1) to head (146da17).

Files Patch % Lines
groqeval/metrics/base_metric.py 92.50% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main       #9      +/-   ##
==========================================
+ Coverage   97.35%   98.78%   +1.42%     
==========================================
  Files          11       11              
  Lines         302      328      +26     
==========================================
+ Hits          294      324      +30     
+ Misses          8        4       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@djokester djokester merged commit ae6c466 into main Jul 11, 2024
1 check passed
@djokester djokester deleted the 2-add-flags-for-aggregation-and-verbosity branch July 11, 2024 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Flags for Aggregation and Verbosity
2 participants