fix #1052: template tag inside template tag #1053
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for djlint canceled.
|
oliverhaas
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Check List
Resolves: #1052
(no real need to update docs)
This is a quick fix.
Overall I think djlint should be refactored in some regards.
Many regexes (like this one I modified) should be using existing basic regexes as building blocks more I think.
Many regexes don't respect nesting of brackets and escaping properly (again, like this one here), and do not respect the differences between what e.g. an attribute key or value.
Both these issues rarely matter, but I could definitely construct valid django templates where they do. Not super easy to fix/refactor, so I'm currently trying to cover some ground with these smaller issues/PRs and get some tests for all of my use cases, so I'm maybe confident enough to refactor some stuff later.