Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added missing migrations #120

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

fix: added missing migrations #120

Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f3478e2
Create 0012_alter_picture_cmsplugin_ptr.py
vasekch May 4, 2023
f910bf2
Update 0012_alter_picture_cmsplugin_ptr.py
vasekch May 4, 2023
0242ae3
Update 0012_alter_picture_cmsplugin_ptr.py
vasekch May 4, 2023
4511bb3
using latest cms migration as a dependency
vasekch Jul 17, 2023
3737f7b
Merge pull request #1 from django-cms/master
vasekch Jul 17, 2023
774e1f7
Update djangocms_picture/migrations/0012_alter_picture_cmsplugin_ptr.py
vasekch Jul 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions djangocms_picture/migrations/0012_alter_picture_cmsplugin_ptr.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
# Generated by Django 4.1.8 on 2023-05-04 15:04

from django.db import migrations, models
import django.db.models.deletion


class Migration(migrations.Migration):

dependencies = [
('cms', '__first__'),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather this be latest.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

latest migration from develop branch

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've changed code to use latest migration found in the develop branch of django-cms repo.

now the code is the same with #118

The original idea was to accommodate cases where users update djangocms-picture, but may keep django-cms in older version than does not includes the latest migration. I've chosen the first migration, because that's where cmsplugin_ptr is created.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think @marksweb referred to '__latest__' instead of '__first__'. This would allow you to keep cms outdated (for whatever reason ;-) )

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking back at this, I think it needs to be __first__ because if if's latest and we release a new migration, the applied migration here would depend on a migration yet to be applied and that causes an error.

('djangocms_picture', '0011_auto_20190314_1536'),
]

operations = [
migrations.AlterField(
model_name='picture',
name='cmsplugin_ptr',
field=models.OneToOneField(on_delete=django.db.models.deletion.CASCADE, parent_link=True, primary_key=True, related_name='%(app_label)s_%(class)s', serialize=False, to='cms.cmsplugin'),
),
]