fix: File expand url incorrect and worked not with custom image models #1471
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1470:
fa385bd2b4b3022f54499bbb3c603d463f4baf2e removed the
_view
suffix from url name leading to an empty link.Also, if the
Image
model is replaced by a custom model, the reverse name changes, too.This PR moves the generation of the admin urls to the
BaseImage
model where the other admin urls are generated, sucha asget_admin_change_url
etc.Related resources
Checklist
master
Slack to find a “pr review buddy” who is going to review my pull request.