Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Backport of #7868 and #7920 #7926

Merged
merged 4 commits into from
May 24, 2024
Merged

fix: Backport of #7868 and #7920 #7926

merged 4 commits into from
May 24, 2024

Conversation

fsbraun
Copy link
Sponsor Member

@fsbraun fsbraun commented May 22, 2024

Description

This ports the fixes #7868 and #7920 back to django CMS 3.11

Related resources

Checklist

  • I have opened this pull request against develop-4
  • I have added or modified the tests when changing logic
  • I have followed the conventional commits guidelines to add meaningful information into the changelog
  • I have read the contribution guidelines and I have joined the channel #pr-reviews on our Discord Server to find a “pr review buddy” who is going to review my pull request.

fsbraun and others added 2 commits May 22, 2024 10:05
@fsbraun
fix: Only switch to structure endpoint on viewport breakpoint if in e…
7217a2f 
…dit mode (#7920)
@jrief @fsbraun
fix: #7859: allow special characters in page title (#7868)
f8c946e 
* fix #7859: allow special characters in page title

* Update test_templatetags.py

* Fix ruff issues in test_templatetags.py

* One more time: fix ruff issues in test_templatetags.py

---------

Co-authored-by: Fabian Braun <[email protected]>
@fsbraun fsbraun requested a review from a team May 22, 2024 08:13
@fsbraun fsbraun marked this pull request as draft May 23, 2024 18:52
@fsbraun fsbraun marked this pull request as ready for review May 23, 2024 19:55
@fsbraun fsbraun merged commit d2c2cb5 into release/3.11.x May 24, 2024
72 of 75 checks passed
@fsbraun fsbraun deleted the chore/backport-fixes branch May 24, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marksweb marksweb marksweb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fsbraun @marksweb @jrief