perf: small reduction of DB queries #7887
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrief
changed the title
marksweb
changed the title
marksweb
force-pushed
the
fix-reduce-db-queries
branch
from
e6890d7 to
42d2717
Compare
|
I like the How does caching the fallback languages help performance. The fallback languages only depend on the settings, or am I missing something? |
|
@jrief Are there any updates on this? Also, would be great to see the number of queries reduction shown by Django Debug Tool or something? In my opinion, it would be help remember the rationale behind the change in future. |
marksweb
force-pushed
the
fix-reduce-db-queries
branch
from
0a94ec4 to
49c4dbc
Compare
fsbraun
added a commit
to fsbraun/django-cms
that referenced
this pull request
Jul 29, 2024
fsbraun
added a commit
that referenced
this pull request
Aug 7, 2024
…7956) * Refactor cms_menus.py: CPU time saving ~45% (measured with ~50.000 pages) * Remove page content lookup from the loop * Fix db accesses * Optimize menu tags, especially `cut_levels * Fix EmptyPageContent regression * chore: update signature of `cut_after * Refactor cms_menus * Save one big query: Remove the need for page content prefetch (saving one big query) by building the nodes based on page content objects instead of page objects * Adjust tests and add release note deprecation information * Remove debugging code * Update test to reflect lower query number * Respect PageContentAdmin `get_queryset` in pagetree. * Refactor cms_menus.py: CPU time saving ~45% (measured with ~50.000 pages) * Remove page content lookup from the loop * Fix db accesses * Optimize menu tags, especially `cut_levels * Fix EmptyPageContent regression * chore: update signature of `cut_after * Refactor cms_menus * Save one big query: Remove the need for page content prefetch (saving one big query) by building the nodes based on page content objects instead of page objects * Adjust tests and add release note deprecation information * Remove debugging code * Update test to reflect lower query number * Respect PageContentAdmin `get_queryset` in pagetree. * Add docsstrings * Improve naming * Add compatibility shim for `get_node_for_page` function. * Fix deprecation warning * Extend tests * Add deprecation message to Level modifier docstring * Ensure availability of `languages` property in `CMSMenu * Optimize page content admin by prefetching the page object * Update docstrings * Query optimization from #7887 * Remove duplicate `"page__is_home"` from `.only()` expression
|
@jrief One change has been merged into django-cms/cms/models/pagemodel.py Line 780 in 59d50f2 Can we close this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR reduces the number of DB queries by a few.
Related resources
Pageobject..filter(…)on the queryset against.all()actually reduces the number of queries. This is because that queryset in most cases is already consumed. Calling it with.filter(…)actually fetches the data a second time. Therefore filtering in Python is cheaper, especially if the number of languages never exceeds a significant number.Also read https://docs.djangoproject.com/en/5.0/ref/models/querysets/#values
Checklist
develop-4