Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Re-introduce page-level publish permission just as in v4.0 #7837

Open
wants to merge 14 commits into
base: develop-4
Choose a base branch
from

Conversation

fsbraun
Copy link
Sponsor Member

@fsbraun fsbraun commented Mar 11, 2024

Description

In django CMS version 4.1 the can_publish permission was removed. With the next release of djangocms-versioning it will support low-level publication permissions if the versioned content model supports it.

This PR restores the can_publish permissions and its test as it was available in django CMS 4.0.

Tests have been restored, too.

A (no-op) squashed migration was added to ensure that publish permissions are not lost during migration processes:

  • 0035 removes page publish permissions (released in 4.1.0)
  • 0036 adds the page publish permissions back
  • Squashed migration 0035 replaces 0035 and 0036 with a no-op

Related resources

Checklist

  • I have opened this pull request against develop-4
  • I have added or modified the tests when changing logic
  • I have followed the conventional commits guidelines to add meaningful information into the changelog
  • I have read the contribution guidelines and I have joined #workgroup-pr-review on Slack to find a “pr review buddy” who is going to review my pull request.

@fsbraun fsbraun requested review from marksweb and jrief March 11, 2024 09:50
@fsbraun fsbraun added the 4.1 label Mar 12, 2024
Copy link
Member

@vinitkumar vinitkumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fsbraun I was wondering if it's possible to have test covering this change, just so that if there are regressions in this part of code, we can catch it.

@fsbraun
Copy link
Sponsor Member Author

fsbraun commented May 20, 2024

@vinitkumar The publish permissions are tested. When they were removed, they were removed with their tests... Now, this PR brings both permissions and tests back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Review required
Development

Successfully merging this pull request may close these issues.

None yet

2 participants