fix: Refactor CMSMenu class for easier subclassing #7832
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
CMSMenu
class has been updated in #7807 for efficient and versioning-compatible menus.This PR factors out two major changes to allow for future subclassing (such as asked for in django-cms/djangocms-versioning#387):
CMSMenu.get_pagecontent_queryset
: returns the queryset to build the menu. The default implementation includes the admin-visiblelatest_content
, e.g. not yet published pages, in edit and preview modeCMSMenu.preview_endpoint
: returns a callable to get an endpoint for the menu entry. The default implementation returns the preview endpoint in edit or preview mode.The PR does not change the logic of how
CMSMenu
works.Related resources
CMSMenu.get_nodes()
returns URLs of unpublished pages djangocms-versioning#387Checklist
develop-4