Skip to content

Commit

Permalink
Fix: Broken page actions menu if CMS_PERMISSIONS is set
Browse files Browse the repository at this point in the history
  • Loading branch information
@fsbraun
fsbraun committed Aug 24, 2023
1 parent ac74c21 commit 33f93d6
Showing 1 changed file with 0 additions and 12 deletions.
12 changes: 0 additions & 12 deletions cms/templates/admin/cms/page/tree/actions_dropdown.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -72,18 +72,6 @@
<span>{% trans "Advanced settings" %}</span>
</a>
</li>
{% if CMS_PERMISSION %}
<li>
{% if has_change_permissions_permission %}
<a href="{% url opts|admin_urlname:'permissions' page.id %}" title="{% filter escapejs %}{% trans "Permissions" %}{% endfilter %}">
{% else %}
<a href="#" class="cms-pagetree-dropdown-item-disabled">
{% endif %}
<span class="cms-icon cms-icon-lock"></span>
<span>{% trans "Permissions" %}</span>
</a>
</li>
{% endif %}
{% endblock actions %}
<li class="cms-pagetree-dropdown-separator">&nbsp;</li>
<li>
Expand Down

2 comments on commit 33f93d6

@stefanw
Copy link
Contributor

@stefanw stefanw commented on 33f93d6 Sep 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fsbraun Instead of removing this, you can change opts|admin_urlname:'permissions' to opts|admin_urlname:'get_permissions' and it works again.

@fsbraun
Copy link
Member Author

@fsbraun fsbraun commented on 33f93d6 Sep 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @stefanw ! Thanks for looking into this! Permissions have been moved into the advanced settings, though. Also, if I do not remember this wrongly, but get_permissions does not give you the permissions form (as it has moved into the advanced settings).

Please sign in to comment.