-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rotate labels #54
base: develop
Are you sure you want to change the base?
Rotate labels #54
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is definitely heading down the right lines, but one crucial thing is missing - the rotation of the label isn't accounted for in the bounding cuboids, which means that the layout is generated incorrectly. To illustrate this, run the basic
example, set the Y-axis title to "Vertical", and put in a long title. It's clear that the graph area is reacting to an increase in only the horizontal (un-rotated) size of the label.
Oops! Yes you are right - I hadn't thought about that. |
Regarding this, at which point do you think the rotation should be performed? In reference to the |
I think I'd be tempted to add another argument to the second |
…achieve alignment about Z.
Co-authored-by: Tristan Youngs <[email protected]>
…l calculated incorrectly).
f192f1e
to
60f09cc
Compare
Relatively small PR that enables a
TextEntity
to be rotated. This is aimed in particular at Axis Titles.TextAlignment
enum for defining rotation of text (currently horizontal / vertical).TextEntity
class.AxisEntity
class.Current issues:
Closes #13.