Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Visual Studio dev environment CI job #2047

Draft
wants to merge 31 commits into
base: develop
Choose a base branch
from

Conversation

RobBuchananCompPhys
Copy link
Contributor

No description provided.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: 5d25040 Previous: 3a49e5e Ratio
BM_Box_MinimumVector<CubicBox> 12.17687222252751 ns/iter 5.605181720829965 ns/iter 2.17

This comment was automatically generated by workflow using github-action-benchmark.

CC: @disorderedmaterials/dissolve-devs

Copy link
Member

@trisyoungs trisyoungs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good! So the _ was the key?

@RobBuchananCompPhys
Copy link
Contributor Author

@trisyoungs It appears that it hasn't worked. I still can't see the Msvc action running, even though the PR contains changed to develop.ps1, and that should trigger it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants