broadenedTR added to TR module #2034
Open
+230
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 1192907.
Danbr4d
force-pushed
the
tr-broadening
branch
from
1072bf2 to
d55dad5
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.
| Benchmark suite | Current: f920f83 | Previous: a61638e | Ratio |
|---|---|---|---|
BM_Box_MinimumDistance<CubicBox> |
17.432889804294614 ns/iter |
5.671768850847747 ns/iter |
3.07 |
BM_Box_MinimumDistanceSquared<CubicBox> |
18.040541376176296 ns/iter |
5.598936994065313 ns/iter |
3.22 |
BM_Box_MinimumDistance<OrthorhombicBox> |
17.410151282217303 ns/iter |
5.352243727138727 ns/iter |
3.25 |
BM_Box_MinimumDistanceSquared<OrthorhombicBox> |
17.412168083992864 ns/iter |
5.631994645033911 ns/iter |
3.09 |
BM_Box_MinimumDistance<MonoclinicAlphaBox> |
17.420973279816295 ns/iter |
5.604479397391105 ns/iter |
3.11 |
BM_Box_MinimumDistanceSquared<MonoclinicAlphaBox> |
17.415885406220756 ns/iter |
4.9961470077808565 ns/iter |
3.49 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @disorderedmaterials/dissolve-devs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added in the ability to calculate the TR from the FT partialSQs into the TR module