fix: Size factor persisted after node was removed (#2013)

disorderedmaterials · Nov 20, 2024 · 6f707b2 · 6f707b2
1 parent 6130ea2
commit 6f707b2
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 0 deletions.
diff --git a/src/classes/configuration.cpp b/src/classes/configuration.cpp
@@ -98,6 +98,7 @@ bool Configuration::initialiseContent(const GeneratorContext &generatorContext)
     empty();
 
     appliedSizeFactor_ = std::nullopt;
+    requestedSizeFactor_ = defaultSizeFactor_;
 
     // Run the generator Generator
     if (!generate(generatorContext))

diff --git a/src/generator/sizeFactor.cpp b/src/generator/sizeFactor.cpp
@@ -11,6 +11,13 @@ SizeFactorGeneratorNode::SizeFactorGeneratorNode() : GeneratorNode(NodeType::Siz
     keywords_.add<NodeValueKeyword>("SizeFactor", "Size factor scaling to apply to configuration", sizeFactor_, this);
 }
 
+/*
+ * Identity
+ */
+
+// Return whether a name for the node must be provided
+bool SizeFactorGeneratorNode::mustBeNamed() const { return false; }
+
 /*
  * Execute
  */

diff --git a/src/generator/sizeFactor.h b/src/generator/sizeFactor.h
@@ -16,6 +16,13 @@ class SizeFactorGeneratorNode : public GeneratorNode
     private:
     NodeValue sizeFactor_{10.0};
 
+    /*
+     * Identity
+     */
+    public:
+    // Return whether a name for the node must be provided
+    bool mustBeNamed() const override;
+
     /*
      * Execute
      */