build: Enable cppCheck tests on ci (#2048)

.github/workflows/qc/action.yml

@@ -76,3 +76,11 @@ runs:
       git diff
       # Run quiet diff to fail the job if any changes were made (see man git-diff)
       git diff --quiet
+
+  - name: Cpp Check
+    shell: bash
+    run: |
+      set -ex
+      MAX_ERRORS=3
+      MAX_WARNINGS=1
+      nix develop -L --command scripts/cppCheckTest.sh $MAX_ERRORS $MAX_WARNINGS

flake.nix

@@ -158,6 +158,7 @@
               cmake-format
               cmake-language-server
               conan
+              cppcheck
               direnv
               gdb
               gtk3

scripts/cppCheckTest.sh

@@ -0,0 +1,30 @@
+#!/bin/sh
+
+set -e
+
+if [ "$#" -ne 2 ]; then
+    echo "Usage: $0 MAX_ERRORS MAX_WARNINGS" >&2
+    exit 1
+fi
+
+MAX_ERRORS=$1
+MAX_WARNINGS=$2
+
+# Use or true because the script should continue even if cppcheck fails
+cppcheck --check-level=exhaustive src 2> check.log || true
+
+ERRORS=$( cat check.log | grep -c "error:" )
+WARNINGS=$( cat check.log | grep -c "warning:" )
+
+if [ "$ERRORS" -gt "$MAX_ERRORS" ]; then
+    cat check.log
+    echo "Wanted $MAX_ERRORS errors, but found $ERRORS"
+    false
+else
+
+    if [ "$WARNINGS" -gt "$MAX_WARNINGS" ]; then
+        cat check.log
+        echo "Wanted $MAX_WARNINGS warnings, but found $WARNINGS"
+        false
+    fi
+fi

src/classes/partialSet.cpp

@@ -119,9 +119,9 @@ void PartialSet::reset()
         ParallelPolicies::par, 0, atomTypeMix_.nItems(),
         [&](int i, int j)
         {
-            std::fill(partials_[{i, j}].values().begin(), partials_[{i, j}].values().end(), 0.0);
-            std::fill(boundPartials_[{i, j}].values().begin(), boundPartials_[{i, j}].values().end(), 0.0);
-            std::fill(unboundPartials_[{i, j}].values().begin(), unboundPartials_[{i, j}].values().end(), 0.0);
+            std::ranges::fill(partials_[{i, j}].values(), 0.0);
+            std::ranges::fill(boundPartials_[{i, j}].values(), 0.0);
+            std::ranges::fill(unboundPartials_[{i, j}].values(), 0.0);
             emptyBoundPartials_[{i, j}] = true;
         },
         half_);

src/data/sginfo/sgsi.c

@@ -5,10 +5,6 @@
 #include <stdio.h>
 #include <stdlib.h>
 
-#ifdef APP_INCLUDE
-#include APP_INCLUDE
-#endif
-
 #ifndef AppMalloc
 #define AppMalloc(ptr, n) (ptr) = malloc((n) * sizeof(*(ptr)))
 #endif

src/gui/addConfigurationDialog.cpp

@@ -188,6 +188,8 @@ void AddConfigurationDialog::finalise()
 
         // Add a GeneralRegion node
         regionNode = generator.createRootNode<GeneralRegionGeneratorNode>({});
+        if (!regionNode)
+            Messenger::exception("Failed to create root node");
         regionNode->keywords().set("Tolerance", 5.0);
     }
     else