Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propose parallel path #4

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Propose parallel path #4

wants to merge 1 commit into from

Conversation

rprospero
Copy link
Contributor

Does everyone feel this matches our discussion from the sprint review?

Copy link
Member

@DanNixon DanNixon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the other thing missing from the background information is the relative differences in workload expected on different systems. e.g. how much should someone be able to do on a laptop?

moves the code base into a position that will be easier to parallelize
through one of the GPU libraries

### 3) CyCL
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### 3) CyCL
### 3) SYCL

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And throughout the following paragraphs.

3. [OpenMP](https://openmp.org)
4. [CUDA](https://developer.nvidia.com/cuda-zone)
5. [OpenCL](https://www.khronos.org/opencl/)
6. [CyCL](https://www.khronos.org/sycl/)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
6. [CyCL](https://www.khronos.org/sycl/)
6. [SYCL](https://www.khronos.org/sycl/)

@@ -0,0 +1,137 @@
# Print Formatting
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Title needs to be updated.

- Good, supported by most common C++ compilers
- Good, support for multiple cores and vector instructions
- Good, requires simple annotations of existing for-loops
- Bad, weak support for advanced hardware (GPU code)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not the case, OpenMP can target GPUs. It is only in the latest spec IIRC but there is support for at least some Nvidia GPUs from what I recall.

moves the code base into a position that will be easier to parallelize
through one of the GPU libraries

### 3) CyCL
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And throughout the following paragraphs.

@trisyoungs
Copy link
Member

I think the other thing missing from the background information is the relative differences in workload expected on different systems. e.g. how much should someone be able to do on a laptop?

Fair comment. Depends how much detail we want to go in to here, but happy to chip in on this bit.

@DanNixon
Copy link
Member

I think the other thing missing from the background information is the relative differences in workload expected on different systems. e.g. how much should someone be able to do on a laptop?

Fair comment. Depends how much detail we want to go in to here, but happy to chip in on this bit.

On second thought, it is more the kind of information I would expect in a design document and not too relevant here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants