Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Include Gudrun dependencies in the run #513

Merged
merged 17 commits into from
Jun 28, 2024

Conversation

rhinoella
Copy link
Contributor

@rhinoella rhinoella commented May 29, 2024

This PR makes sure that the necessary dependencies for gudrun are included in the running environment, such as the selfscatteringfile which is used by the inelasticity iterator.

It also serves to improve the output file management, instead of passing around a object to refer the run files, the outputs of the runs are stored within the dataFiles objects.

Copy link

github-actions bot commented May 29, 2024

Test Results

  3 files    3 suites   42m 48s ⏱️
 93 tests  93 ✅ 0 💤 0 ❌
279 runs  279 ✅ 0 💤 0 ❌

Results for commit 0807979.

♻️ This comment has been updated with latest results.

@rhinoella rhinoella requested a review from trisyoungs June 27, 2024 15:06
Copy link
Member

@trisyoungs trisyoungs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

👍

@rhinoella rhinoella merged commit 59c93f6 into develop Jun 28, 2024
9 checks passed
@rhinoella rhinoella deleted the inelasticity-iterator-2 branch June 28, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants