Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Import from project - Improved IO Management #508

Merged
merged 80 commits into from
May 29, 2024
Merged

feat: Import from project - Improved IO Management #508

merged 80 commits into from
May 29, 2024

Conversation

rhinoella
Copy link
Contributor

No description provided.

rhinoella added 26 commits May 10, 2024 15:01
@rhinoella
Store output in data
eb3e895
@rhinoella
Create separate parser classes
c538162
@rhinoella
Create dedicated iO handling
2f6f6a3
@rhinoella
Update functions
beefca0
@rhinoella
Continue refactoring
af58312
@rhinoella
Apply breaking changes
576fc22
@rhinoella
Fix checks
6ce452d
@rhinoella
Fix YAML imports
6c89dde
@rhinoella
Fix instrument parsing
e8bc324
@rhinoella
Fix export, update test project
317d618
@rhinoella
Merge branch 'develop' of https://github.com/disorderedmaterials/GudPy …
739410b 
…into inelasticity-iterator
@rhinoella
Lint, delete gudpy_yaml.py
8604ee3
@rhinoella
Small bug fixes
ba9e8bc
@rhinoella
Lint: remove unused import
5f9209f
@rhinoella
Test path fis
39aacf8
@rhinoella
Text updating
8594fd6
@rhinoella
Syntax fix
904ec39
@rhinoella
Remove unused import, allow tests without lint
a0ad5e5
@rhinoella
update test
912970b
@rhinoella
Revert error message
df2b130
@rhinoella
Add output folder attr to tests
3f3d212
@rhinoella
Update tests
a8c3854
@rhinoella
Add writeGudrunFileTo method
e1a141d
@rhinoella
Switch to correct parser
234eeeb
@rhinoella
Add decorator
2ed178a
@rhinoella
Bugfixes
9b6b813
@rhinoella rhinoella changed the title Import from project - Improved IO Management feat: Import from project - Improved IO Management May 22, 2024
rhinoella added 22 commits May 28, 2024 09:58
@rhinoella rhinoella changed the base branch from develop to release/0.2.2 May 28, 2024 14:04
@rhinoella rhinoella changed the base branch from release/0.2.2 to develop May 28, 2024 14:04
@rhinoella rhinoella requested a review from trisyoungs May 28, 2024 14:04
trisyoungs
trisyoungs reviewed May 28, 2024
View reviewed changes
Copy link
Member

@trisyoungs trisyoungs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another nice small PR! 😄
As well as refactoring the IO, this presumably also fixes inelasticity iteration (given the source branch name)? You didn't provide a PR description, so just checking.

@rhinoella
Copy link
Contributor Author

Another nice small PR! 😄 As well as refactoring the IO, this presumably also fixes inelasticity iteration (given the source branch name)? You didn't provide a PR description, so just checking.

That was the intention when I created the branch, but then I realised I needed to sort out the IO first. Apologies for forgetting a description.

@rhinoella rhinoella merged commit 9b591b0 into develop May 29, 2024
9 checks passed
@rhinoella rhinoella deleted the inelasticity-iterator branch May 29, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trisyoungs trisyoungs trisyoungs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rhinoella @trisyoungs