Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load GudPy work from project folder #479

Merged
merged 159 commits into from
Feb 13, 2024
Merged

Load GudPy work from project folder #479

merged 159 commits into from
Feb 13, 2024

Conversation

rhinoella
Copy link
Contributor

@rhinoella rhinoella commented Jan 17, 2024

Allows GudPy to be loaded from a previously outputted project folder. Supports the move from input files to project folders in #457.

  • GudPy still supports loading from input files
  • When an input file is loaded, when the user sets a save location, a project folder is created there and a new copy of the input file will exist there (GudPy will not overwrite existing input files outside of a project folder)

@rhinoella rhinoella changed the base branch from develop to outputs-fix-2 January 25, 2024 09:38
Base automatically changed from outputs-fix-2 to develop January 25, 2024 12:47
@rhinoella rhinoella changed the base branch from develop to release/0.2.2 January 25, 2024 14:34
@rhinoella rhinoella changed the base branch from release/0.2.2 to develop January 25, 2024 14:35
@rhinoella rhinoella changed the base branch from develop to np-window-title January 25, 2024 14:39
@rhinoella rhinoella changed the base branch from np-window-title to develop January 25, 2024 14:39
Copy link

github-actions bot commented Jan 26, 2024

Test Results

  3 files    3 suites   1h 1m 22s ⏱️
 93 tests  93 ✅ 0 💤 0 ❌
279 runs  279 ✅ 0 💤 0 ❌

Results for commit 506ddc8.

♻️ This comment has been updated with latest results.

Copy link
Member

@trisyoungs trisyoungs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking through this really made me appreciate what a nice idea this was in the first place. I fully believe this is how it should be.

Few minor comments (questions, really, for my own benefit!) to address before merging, but otherwise looks good.

gudpy/core/gud_file.py Show resolved Hide resolved
gudpy/gui/widgets/core/main_window.py Show resolved Hide resolved
gudpy/gui/widgets/core/main_window.py Show resolved Hide resolved
gudpy/gui/widgets/core/main_window.py Show resolved Hide resolved
@rhinoella rhinoella merged commit ef566fb into develop Feb 13, 2024
9 checks passed
@rhinoella rhinoella deleted the load-project branch February 13, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants