Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade to storybook@8 #46

Merged
merged 11 commits into from
Jul 27, 2024
Merged

chore: upgrade to storybook@8 #46

merged 11 commits into from
Jul 27, 2024

Conversation

marcustyphoon
Copy link
Collaborator

@marcustyphoon marcustyphoon commented Jun 20, 2024

  • check this side-by-side with the current storybook to ensure no options/panes/whatever are obviously missing

Well this absolutely sucked to do. But we have 0 security warnings after this!

@marcustyphoon marcustyphoon marked this pull request as draft June 20, 2024 22:54
@marcustyphoon marcustyphoon changed the title chore: upgrade to storybook@8 feat: upgrade to storybook@8 Jun 20, 2024
@marcustyphoon marcustyphoon changed the title feat: upgrade to storybook@8 chore: upgrade to storybook@8 Jun 20, 2024
@marcustyphoon
Copy link
Collaborator Author

Re: the last couple of commits. We have a choice between having the RDC storybook

  • Use a webpack override to import and use a compiled version of gw2-ui (which it gets via symlink from the "@discretize/gw2-ui-new": "workspace:^", package dependency due to PNPM). This requires the import '@discretize/gw2-ui-new/dist/index.css'; line and will only update gw2-ui when the developer runs the build script.
  • import the unbuilt gw2-ui source and feed it, including raw css modules, to webpack. This enables hot reload, instantly updating the RDC storybook when the developer saves changes to gw2-ui. It also breaks the import '@discretize/gw2-ui-new/dist/index.css'; line since the source doesn't have a file called index.css.
  • Split the difference in dev and prod. This... doesn't really work.

@gw2princeps
Copy link
Member

Option 2 seems most sensible to me. What option are you leaning towards?

@marcustyphoon
Copy link
Collaborator Author

I implemented option 2! Seems to work well.

@marcustyphoon marcustyphoon marked this pull request as ready for review July 8, 2024 09:53
@marcustyphoon marcustyphoon changed the base branch from dependencies to main July 9, 2024 00:23
@gw2princeps gw2princeps merged commit 2ff6709 into main Jul 27, 2024
1 check passed
@gw2princeps gw2princeps deleted the storybook-8-webpack branch July 27, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants