Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update package dependencies #43

Merged
merged 14 commits into from
Jul 8, 2024
Merged

chore: update package dependencies #43

merged 14 commits into from
Jul 8, 2024

Conversation

marcustyphoon
Copy link
Collaborator

@marcustyphoon marcustyphoon commented Jun 20, 2024

  • moves some dependencies out of package dependencies fields that the packages don't use and shouldn't install, or that should be peer dependencies
  • updates rollup to v4 and updates various other build dependencies
  • updates typescript, but only to v4.7; later versions break https://github.com/woutervh-/typescript-is, an abandoned project used in pnpm --filter @discretize/gw2-ui-new api-typecheck that we should replace with https://github.com/samchon/typia
  • bumps three package minor versions (none of this should be breaking, but it does change output and dependencies, so we should deploy)

we should also, at some point, probably update to storybook@8.

@marcustyphoon
Copy link
Collaborator Author

marcustyphoon commented Jun 29, 2024

Wait a second... gw2-ui shouldn't have a direct dependency on react. I'll have to look into that.

@marcustyphoon marcustyphoon marked this pull request as draft June 29, 2024 05:47
@marcustyphoon marcustyphoon removed the request for review from gw2princeps June 29, 2024 05:47
@marcustyphoon marcustyphoon marked this pull request as ready for review July 7, 2024 21:29
this is wrong but I can't be bothered to fix it
@gw2princeps gw2princeps merged commit 889a6d2 into main Jul 8, 2024
1 check passed
@marcustyphoon marcustyphoon deleted the dependencies branch July 9, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants