Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UX: add styling for floating topic button edge cases #32

Merged
merged 2 commits into from
Aug 8, 2024

Conversation

chapoi
Copy link
Contributor

@chapoi chapoi commented Aug 8, 2024

The floating topic button overlaps with the chat-drawer, reported https://meta.discourse.org/t/new-thread-button-covers-chat-input-area/320189

This commit:

  • lowers the z-index of the button, ensuring it's lower than the chat-drawer
  • adds conditional positioning to avoid the button overlapping with a minimised chat drawer or composer – it's not perfectly smart but it's an improvement for most states

@chapoi chapoi merged commit a59f844 into main Aug 8, 2024
3 checks passed
@chapoi chapoi deleted the floating-topic-button-visibility branch August 8, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants