Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document set voice channel status #6398

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Document set voice channel status #6398

wants to merge 8 commits into from
+34 −16

Conversation

MinnDevelopment
Copy link
Contributor

Permission:

image

Usage:

image

image

@MinnDevelopment MinnDevelopment mentioned this pull request Sep 2, 2023
Merged
6 tasks
@sdanialraza sdanialraza mentioned this pull request Sep 2, 2023
Draft
@sebm253 sebm253 mentioned this pull request Sep 2, 2023
Closed
@spifory spifory mentioned this pull request Sep 2, 2023
Draft
3 tasks
This was referenced Sep 3, 2023
Closed
Closed
mccoderpy added a commit to mccoderpy/discord.py-message-components that referenced this pull request Sep 3, 2023
@mccoderpy
feat: Add support for voice channel status
c34a462 
discord/discord-api-docs#6398
Signed-off-by: mccoderpy <[email protected]>
@sebm253 sebm253 mentioned this pull request Sep 3, 2023
Draft
advaith1
advaith1 reviewed Sep 4, 2023
View reviewed changes
Copy link
Contributor

@advaith1 advaith1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the name of this PR is outdated

docs/resources/Channel.md
@@ -15,6 +15,7 @@ Represents a guild or DM channel within Discord.
| permission_overwrites? | array of [overwrite](#DOCS_RESOURCES_CHANNEL/overwrite-object) objects | explicit permission overwrites for members and roles |
| name? | ?string | the name of the channel (1-100 characters) |
| topic? | ?string | the channel topic (0-4096 characters for `GUILD_FORUM` and `GUILD_MEDIA` channels, 0-1024 characters for all others) |
| status? | ?string | the voice channel status (0-500 characters) |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| status? | ?string | the voice channel status (0-500 characters) |
| status? | ?string | the voice channel status (0-500 characters), only included in the Guild Create event |

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason for this?

advaith1
advaith1 reviewed Sep 4, 2023
View reviewed changes
docs/topics/Permissions.md Outdated Show resolved Hide resolved
@advaith1 advaith1 mentioned this pull request Sep 4, 2023
Draft
@FedorLap2006 FedorLap2006 mentioned this pull request Sep 4, 2023
Open
@Earlopain
Copy link

Can documentation for the status field in the auditlog options be added as well?

@MinnDevelopment MinnDevelopment changed the title Add set voice channel status permission Document set voice channel status Sep 4, 2023
VelvetToroyashi added a commit to VelvetToroyashi/Remora.Discord that referenced this pull request Sep 4, 2023
@VelvetToroyashi
feat: Add new permissions
2212473 
This commit implements the new permissions (USE_CLYDE_AI, SET_VOICE_CHANNEL_STATUS, and CREATE_GUILD_EXPRESSIONS) as seen in these PRs:

discord/discord-api-docs#6354
discord/discord-api-docs#6398
discord/discord-api-docs#6120
This was referenced Sep 4, 2023
Open
Open
@advaith1
Copy link
Contributor

advaith1 commented Sep 4, 2023

the Channel Update event description should be updated to say that it doesn't trigger for status updates like last_message_id

sebm253
sebm253 reviewed Sep 6, 2023
View reviewed changes
docs/resources/Audit_Log.md Outdated Show resolved Hide resolved
@MazeXP
Copy link
Contributor

MazeXP commented Sep 6, 2023 •
edited

Can the status field added to the Modify Channel API call added as well

@sebm253
Copy link
Contributor

sebm253 commented Sep 6, 2023

Can the status field added to the Modify Channel API call added as well

a different endpoint is used for changing voice status and a PR for this already exists: #6400

@sdanialraza
Copy link
Contributor

Can you update the documentation for the list of intents as well with the intent required intent for this event?

@Cynosphere
Copy link

It seems to also emit CHANNEL_TOPIC_UPDATE gateway event, which doesn't seem to be documented either.

Only difference is topic instead of status and the fact that this events have been existing for longer (first instance of it my bot saw was on July 11th). They were only ever setting it to null (stage channel related maybe?) and do not fire on normal channel topic updates.

@advaith1
Copy link
Contributor

that is the old name, it was replaced

@Misha-133 Misha-133 mentioned this pull request Sep 21, 2023
Merged
@ManHatos ManHatos mentioned this pull request Sep 23, 2023
Closed
sdanialraza
sdanialraza reviewed Sep 24, 2023
View reviewed changes
docs/topics/Gateway_Events.md

| Field | Type | Description |
|----------|-----------|------------------------------|
| id | snowflake | The channel id |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this supposed to be id or channel_id?

Copy link
Contributor

@Misha-133 Misha-133 Sep 24, 2023 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's just id
example payload:

<- Dispatch [VOICE_CHANNEL_STATUS_UPDATE] : 
{
  "status": "123",
  "id": "111...",
  "guild_id": "490..."
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, thank you!

@sdanialraza
Copy link
Contributor

Can you update the documentation for the list of intents as well with the intent required intent for this event?

@MinnDevelopment Could you do this please?

@Puncher1 Puncher1 mentioned this pull request Oct 7, 2023
Open
6 tasks
@Puncher1
Copy link
Contributor

Puncher1 commented Oct 8, 2023 •
edited

Looks like that there's a bug with the Discord UI. After editing the channel (e.g. the channel's name) the status gets reset (Set a channel status) but the GUILD_CREATE event still has the status in the payload (see below). I assume that it's a UI bug and not a API bug because why should the status be reset if the channel was edited?

image

{
    ...
    "status": "test",
    "name": "voice-111",
    ...
}

@jamesbt365 jamesbt365 mentioned this pull request Oct 18, 2023
Merged
@MCausc78 MCausc78 mentioned this pull request Jan 19, 2024
Open
@bsian03 bsian03 mentioned this pull request Feb 27, 2024
Open
21 tasks
@Icebluewolf Icebluewolf mentioned this pull request Feb 28, 2024
Merged
9 tasks
@RedGuy12
Copy link

Hey, is there any way to get this merged soon?

@owocado owocado mentioned this pull request Mar 20, 2024
Merged
@iiFDCT iiFDCT mentioned this pull request Apr 21, 2024
Draft
@bogomazov
Copy link

Also interested

@xXM0d3reXx
Copy link

any information when official merge? waiting for over half a year now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@advaith1 advaith1 advaith1 left review comments

@sebm253 sebm253 sebm253 left review comments

@Misha-133 Misha-133 Misha-133 left review comments

@Puncher1 Puncher1 Puncher1 left review comments

@sdanialraza sdanialraza sdanialraza left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet