Show preview of offending message in automod logs #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mniip
requested changes
Aug 20, 2024
plugins/automod.py
Outdated
| @@ -273,7 +273,7 @@ async def process_messages(msgs: Iterable[Message]) -> None: | |||
| if any(role.id in exempt_roles for role in msg.author.roles): | |||
| continue | |||
| if (rule := active_rules.get(index)) is not None: | |||
| reason = "Automatic action: message matches pattern {}".format(index) | |||
| reason = format("Automatic action: message matches pattern {}\n||{!i}||", index, msg.content) | |||
There was a problem hiding this comment.
Please include some safeguard against the reason becoming too long to fit in various places. E.g. use match information in match to select a substring around the match.
|
I didn't notice this comment 💀 I've added a length limit of 128, with ellipses app/prepended if it needed to take a subset of the message. It seems to work properly: 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would let us more easily look for false positive detections instead of having to search each user individually
Message content is protected with a spoiler tag and hopefully defanged using !i (seems to enclose in backticks)