Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ticket system #1

Merged
merged 24 commits into from
Apr 12, 2021
Merged

Ticket system #1

merged 24 commits into from
Apr 12, 2021

Conversation

Sodre177
Copy link
Contributor

@Sodre177 Sodre177 commented Mar 9, 2021

Implements a Mod Ticket plugin as specified.

TODO

  • Commands
  • Concurrency locks (particularly on audit reading)
  • Discord error proofing (particularly delivery and expiry)
  • Command and plugin documentation

Copy link
Member

@mniip mniip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You seem obsessed with _names, what's up with that? Should I be too?

plugins/tickets.py Outdated Show resolved Hide resolved
plugins/tickets.py Outdated Show resolved Hide resolved
plugins/tickets.py Outdated Show resolved Hide resolved
plugins/tickets.py Show resolved Hide resolved
plugins/tickets.py Outdated Show resolved Hide resolved
plugins/tickets.py Outdated Show resolved Hide resolved
plugins/tickets.py Outdated Show resolved Hide resolved
plugins/tickets.py Outdated Show resolved Hide resolved
plugins/tickets.py Outdated Show resolved Hide resolved
plugins/tickets.py Outdated Show resolved Hide resolved
Sodre177 added 10 commits March 17, 2021 15:48
Reformat to 80 columns.
Fix imports.
Fix db init.
Use `util.discord.format` for manual mentions.
Move schema definition inline.
Copied `Enum` definitions into db.
Reduced error level for non-existent guild config.
`pager` no longer expects vararg list.
`pager` uses `ReactionMonitor` for reaction handling.
Add `_all_reaction` to `pager` for displaying all pages.
Add `Expired` to `TicketStatus` db enum.
Remove manual quoting from condition formatting.
Store and expect kv config snowflakes as strings.
Remove extraneous `perm_check`.
Move comprehension loading/unloading to usual loops.
Use cancel reaction instead of `c` response to cancel.
Clean up `resolve_ticket`.
Add `tickets append` sub-command.
Generally clean up commands.
Copy link
Member

@mniip mniip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have a code path for when an audit log entry originates from the bot itself?

P.S. There's a number of comments that describe things that are syntactically obvious from the code that follows immediately.

plugins/tickets.py Outdated Show resolved Hide resolved
plugins/tickets.py Show resolved Hide resolved
plugins/tickets.py Outdated Show resolved Hide resolved
plugins/tickets.py Show resolved Hide resolved
plugins/tickets.py Outdated Show resolved Hide resolved
plugins/tickets.py Outdated Show resolved Hide resolved
plugins/tickets.py Show resolved Hide resolved
plugins/tickets.py Show resolved Hide resolved
plugins/tickets.py Show resolved Hide resolved
plugins/tickets.py Show resolved Hide resolved
@mniip mniip marked this pull request as ready for review April 12, 2021 05:52
@mniip mniip merged commit a1468be into main Apr 12, 2021
@mniip mniip deleted the tickets branch August 13, 2021 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants