Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reflect-config.json for GraalVM native-image #33

Merged
merged 1 commit into from
Apr 21, 2020

Conversation

alexarchambault
Copy link
Contributor

@alexarchambault alexarchambault commented Apr 21, 2020

This file makes it easier for directories-jvm users to generate GraalVM images. It marks java.util.Base64 and java.util.Base64$Encoder as possibly obtained / inspected by reflection, as directories-jvm does now.

If it's not done by directories-jvm, users have to

  • first discover, after a possibly lengthy image generation, that these classes are reflected upon, and
  • add these to their GraalVM config files or command-line options.

Whereas if directories-jvm ships that file, they don't have to think about that.

I didn't add tests right now, but if I take the time to look into #32, maybe a native binary could be generated for that CLI, which would ensure there's no regression in reflect-config.json.

The additional settings could be possibly narrowed... I didn't take the time to do it.

@soc soc merged commit 8ebad08 into dirs-dev:master Apr 21, 2020
@soc
Copy link
Collaborator

soc commented Apr 21, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants