Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reload button when the app errors out #22462

Merged
merged 11 commits into from May 13, 2024
Merged

Add reload button when the app errors out #22462

merged 11 commits into from May 13, 2024

Conversation

licitdev
Copy link
Member

Scope

What's changed:

  • Added reload button when the app errors out

image

Potential Risks / Drawbacks

  • Nil

Review Notes / Questions

  • Nil

Related to #22360 where the app errors out but without any action for users to proceed with

Copy link

changeset-bot bot commented May 10, 2024

🦋 Changeset detected

Latest commit: 4150b7c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@directus/app Patch
@directus/api Patch
directus Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

app/src/app.vue Outdated Show resolved Hide resolved
app/src/app.vue Outdated Show resolved Hide resolved
@paescuj
Copy link
Member

paescuj commented May 13, 2024

Should we align the unexpected error message and button action a bit?

For example:

  • Changing the message to "Please try again later" or "Please try again by reloading the page"
  • Changing the button to "Try again"

Copy link
Member Author

@licitdev licitdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@paescuj The unexpected_error_copy is a generic message which is here:

<template #error="{ error, reset }">
<v-info type="danger" :title="t('unexpected_error')" icon="error" center>
{{ t('unexpected_error_copy') }}

Should we add a new string unexpected_error_reload if we need to change it?

On the other hand, I think the "Try Again" button might be misleading as we are doing a reload and not retrying.

@paescuj
Copy link
Member

paescuj commented May 13, 2024

@paescuj The unexpected_error_copy is a generic message which is here:

<template #error="{ error, reset }">
<v-info type="danger" :title="t('unexpected_error')" icon="error" center>
{{ t('unexpected_error_copy') }}

Should we add a new string unexpected_error_reload if we need to change it?

On the other hand, I think the "Try Again" button might be misleading as we are doing a reload and not retrying.

Right. Hmm, I think it would already be sufficient if we drop the "later", so "Please try again". It feels wrong to tell the user to try later, while presenting a reload button at the same time.
This would also make sense for the case under routes/collection.vue.

@licitdev licitdev requested a review from paescuj May 13, 2024 11:44
Copy link
Member

@paescuj paescuj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@paescuj paescuj merged commit 18ba6b4 into main May 13, 2024
4 checks passed
@paescuj paescuj deleted the app-error-action branch May 13, 2024 12:29
@github-actions github-actions bot added this to the Next Release milestone May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants