Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

documentation review #1118

Merged
merged 3 commits into from
Jan 28, 2025
Merged

documentation review #1118

merged 3 commits into from
Jan 28, 2025

Conversation

astjoephysics
Copy link
Collaborator

@astjoephysics astjoephysics commented Jan 28, 2025

Updated documentation as per my allocation in #1114

Landing page had one or two non-``_``'d Sorcha's. Also added a link to the demo notebooks to make explicit how we've validated to anyone coming to the page for review (which meant adding a tag in the notebooks.rst file to reference to). Also was a linguistics pedant and updated the origin of Sorcha as being derived from and not literally meaning "light"/"brightness" :P

Parallelisation/HPC page was more or less perfect, capitalised Slurm in-text, ensured correct usage of in-line code blocks, fixed some command line flags in the Best Practices section being single and not double -'d

@astjoephysics astjoephysics changed the title update landing page documentation review Jan 28, 2025
@astjoephysics astjoephysics marked this pull request as ready for review January 28, 2025 18:21
@astjoephysics astjoephysics merged commit 8b4fcf8 into main Jan 28, 2025
7 checks passed
@mschwamb mschwamb deleted the docreview branch January 28, 2025 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants