Manually Patched Fonts #152
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Issue #103 multiple people found that some icons are missing, depending on which font they were using. For the most part, this happened on MacOS. Since Apple removed the ability to set a custom Font-Fallback as a workaround, I looked into it, because on my Ubuntu machine, everything looked as expected. But on my Macbook, i also had the issue of incomplete Fonts. So i installed FontForge and opened every font in there. I used Source Code Pro as a baseline, as i found the icons used in there the prettiest. I copy-pasted the icons that were missing (And multiple more, but without overwriting existing icons) into the other Fonts. For the DejaVu-Fonts i also scaled the icons up to match the size in Source Code Pro.
Now, i can just load them into Macs Font-Library and use them in iTerm2 with all Icons. This should fix all issues regarding missing symbols.