Improve code according to the static analyzer report #821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SeleznevPavel
force-pushed
the
bugfix/static-analyzer-pangolin
branch
from
9c223ff
to
e8e3029
Compare
hanefi
reviewed
Jun 25, 2024
There was a problem hiding this comment.
Thanks for this PR. Some high level comments:
- We do not really update our libraries directly. If there is something wrong with them, they should be fixed in relevant upstream sources. You can see details on readme files in those directories.
- We now use libgc, and no longer need
free()calls.
| @@ -831,7 +831,7 @@ pgsql_retry_open_connection(PGSQL *pgsql) | |||
| } | |||
| } | |||
|
|
|||
| if (!connectionOk && pgsql->connection != NULL) | |||
| if (!connectionOk || pgsql->connection != NULL) | |||
There was a problem hiding this comment.
I believe this change here is a mistake.
| @@ -4243,7 +4243,7 @@ getExtensionList(void *ctx, PGresult *result) | |||
| } | |||
|
|
|||
| /* now loop over extension configuration, if any */ | |||
| if (extension->config.count > 0) | |||
| if (extension && extension->config.count > 0) | |||
There was a problem hiding this comment.
Not really necessary as we early exit if extension is null.
There was a problem hiding this comment.
static analyzer didn't catch it
| @@ -705,7 +709,7 @@ pretty_print_bytes(char *buffer, size_t size, uint64_t bytes) | |||
| uint sIndex = 0; | |||
| long double count = bytes; | |||
|
|
|||
| while (count >= 10240 && sIndex < 7) | |||
| while (count >= 10240 && sIndex < (sizeof(suffixes) / sizeof(char) - 1)) | |||
There was a problem hiding this comment.
I can understand why we want to remove hard coded array sizes. However, I have some questions:
- Why do you need the
-1? - Why did you divide by
sizeof(char)where elements are actuallychar*?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a static analyzer report on the Postgres kernel and various components. We plan to publish this report to the community in the form of proposals for pull requests. This pull request is in progress and will be updated. I will aks later for review and merge approval.