[#2291] Support the '...' group for alphabetizing fragment spreads #2293
+326
−21
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a group type to the
groups
property of thealphabetize
rule indicating where fragment spreads should be in a selection set.Similarly to the
'*'
group, which stands for "everything else," the'...'
stands for "all fragment spreads."Fixes #2291
Type of change
How Has This Been Tested?
Added the following unit tests, ran
yarn test
and verified that the error messages match the expected ones:...
is at the start...
is between...
is at the endChecklist:
CONTRIBUTING doc and the
style guidelines of this project
Further comments
When working on this change, the display name for a fragment spread was showing
undefined <fragment name>
, which was because there was no name mapping for thatKind
— so I went ahead and added display names for allKind
values, and sorted the map.