Use table output

diglabby · Jun 1, 2020 · f148e40 · f148e40
1 parent c84b6c6
commit f148e40
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/src/Commands/FindMissingTranslations.php b/src/Commands/FindMissingTranslations.php
@@ -87,9 +87,12 @@ private function compareLanguages(string $baseLanguagePath, array $baseLanguageF
 
  $this->error("Found missing translations in /{$languageName}/{$languageFile}:", 'q');
 
+ $missingKetInfo = [];
  foreach ($missingKeys as $missingKey) {
- $this->line("\t\"{$missingKey}\" is not translated to /{$languageName}/{$languageFile}", null, 'q');
+ $missingKetInfo[] = [$languageName, $languageFile, $missingKey];
  }
+
+ $this->table(['locale', 'file', 'key'], $missingKetInfo);
  }
  }
  }

diff --git a/tests/Commands/FindMissingTranslationsTest.php b/tests/Commands/FindMissingTranslationsTest.php
@@ -4,6 +4,7 @@
 
 use Diglabby\FindMissingTranslations\Commands\FindMissingTranslations;
 use Diglabby\FindMissingTranslations\Tests\TestCase;
+use Illuminate\Support\Facades\Artisan;
 
 final class FindMissingTranslationsTest extends TestCase
 {
@@ -17,7 +18,7 @@ public function it_does_not_report_about_synchronized_files()
  '--dir' => __DIR__.'/sync_lang_files',
  '--base' => 'en',
  ]);
- $output = \Artisan::output();
+ $output = Artisan::output();
 
  $this->assertSame(0, $exitCode);
  $this->assertSame('Successfully compared all languages.', trim($output));
@@ -33,9 +34,9 @@ public function it_reports_about_missing_translation_keys()
  '--dir' => __DIR__.'/unsync_lang_files',
  '--base' => 'en',
  ]);
- $output = \Artisan::output();
+ $output = Artisan::output();
 
  $this->assertSame(1, $exitCode);
- $this->assertStringContainsString('"OK" is not translated to /be/a.php', $output);
+ $this->assertStringContainsString('| be | a.php | OK |', $output);
  }
 }