Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sever select to Ethereum status page #17

Open
digitaldonkey opened this issue Mar 13, 2018 · 8 comments
Open

Add sever select to Ethereum status page #17

digitaldonkey opened this issue Mar 13, 2018 · 8 comments

Comments

@digitaldonkey
Copy link
Owner

The Server status page at admin/reports/ethereum currently works only for the default server.

With the refactored Server settings there should be a SELECT field on top, where you can switch the status page to any ACTIVE server.
Ideally we can reach every server config with admin/reports/ethereum/<id>

image

For reference. The Servers are Drupal config Entities now. With the following properties.

id: infura_ropsten
label: 'Infura Ropsten test network'
url: 'https://ropsten.infura.io/drupal'
network_id: '3'
is_enabled: true
description: 'Infura (https://www.infura.io) provides access to Ethereum Nodes, so that you don''t require to host you own.'

@digitaldonkey
Copy link
Owner Author

Updated in 70ff1a1#diff-28ce30da17769de7dd390cff37d71c70

The screen now different. A server selector would still be interesting.

image

@foxtrotcharlie
Copy link
Contributor

foxtrotcharlie commented Sep 2, 2018

I'd be keen to help on this, if it's still relevant? So is the idea to have something like this, possibly without the submit button so that it automatically submits when changed:

image

...where you can switch the status page to any ACTIVE server.

By 'active' do you mean servers that are enabled (is_enabled: true)?

@amateescu
Copy link
Collaborator

@foxtrotcharlie that looks great! I think that screenshot is exactly what @digitaldonkey wanted to have on this page.

By 'active' do you mean servers that are enabled (is_enabled: true)?

Yup :)

@digitaldonkey
Copy link
Owner Author

digitaldonkey commented Sep 7, 2018

Great. Do you use a Drupal rendered Select? It looks a little unstyled.

Default value should be the current default server and all active servers should be selectable.
We could also parameterize the page like reports/ethereum/machine_name

Would be happy for a PR.

@foxtrotcharlie
Copy link
Contributor

Thanks for the feedback @digitaldonkey & @amateescu! Yes, it is a Drupal rendered select. Working on parameterising the page. Will submit PR once done.

@foxtrotcharlie
Copy link
Contributor

Would one of you mind having a look here please: #35 ?

I have some questions. Thanks!

@jeffanthony
Copy link
Contributor

Should networks or perhaps even nodes become an Entity in itself to extend their usefulness overall?

@digitaldonkey
Copy link
Owner Author

Should networks or perhaps even nodes become an Entity in itself to extend their usefulness overall?

They both are config entities. Just without a UI implemented. You are welcome to add it.

Can you elaborate on how it would improve the usefulness from your perspective?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants