load_document: Lower priority of HTML inputs #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a bug with activitypub related documents: The schema "https://www.w3.org/ns/activitystreams" renders the spec if "application/json" has a lower prioritisation than "text/html".
anatoly-scherbakov
suggested changes
Oct 18, 2023
| @@ -6568,10 +6568,10 @@ def load_document(url, | |||
| :return: True if the value is an absolute IRI, False if not. | |||
| """ | |||
| headers = { | |||
| 'Accept': 'application/ld+json, application/json;q=0.5' | |||
| 'Accept': 'application/ld+json, application/json;q=0.8' | |||
There was a problem hiding this comment.
We define headers['Accept'] here…
| } | ||
| # FIXME: only if html5lib loaded? | ||
| headers['Accept'] = headers['Accept'] + ', text/html;q=0.8, application/xhtml+xml;q=0.8' | ||
| headers['Accept'] = headers['Accept'] + ', text/html;q=0.5, application/xhtml+xml;q=0.5' |
There was a problem hiding this comment.
…and we modify that value here.
- Would it be possible to specify the final value right away?
- Probably a comment explaining what the magic
0.5means would also be helpful to future readers.
|
This looks fine generally, but lets get some tests written for it. @anatoly-scherbakov would you be up for doing that to test out the "local tests" you were sad we didn't have here? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug with activitypub related documents: The schema "https://www.w3.org/ns/activitystreams" renders the spec if "application/json" has a lower prioritisation than "text/html".