Add *Conn.ListHeader to retrieve stats about ipsets #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also expanded SetPolicy to include returned CreateData and expanded CreateData to include kernel-originated fields.
corny
requested changes
Oct 13, 2020
conn_test.go
Outdated
| @@ -298,6 +298,45 @@ func TestConn_List(t *testing.T) { | |||
| m.AssertExpectations(t) | |||
| } | |||
|
|
|||
| func TestConn_ListHeader(t *testing.T) { | |||
| assert2 := assert.New(t) | |||
There was a problem hiding this comment.
please use assert := assert.New(t)
There was a problem hiding this comment.
Would you like all instances in the file changed? Every other use is assert2 := assert.New(t).
|
What's the likelihood of getting this merged and released soonish? |
|
Any chance for a re-review sometime soon? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also expanded
SetPolicyto include returnedCreateDataand expandedCreateDatato include kernel-originated fields.