Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve (arg-)max/minimum #20

Merged
merged 2 commits into from
Feb 1, 2025
Merged

Improve (arg-)max/minimum #20

merged 2 commits into from
Feb 1, 2025

Conversation

kchanqvq
Copy link
Contributor

@kchanqvq kchanqvq commented Jan 25, 2025

Thanks for being so responsive! These are the commits split from my last PR, as requested :)

Copy link
Owner

@digikar99 digikar99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the two minor points, the other addition this PR requires would be analogous changes to the src/basic-math/* files for numericals.

@kchanqvq
Copy link
Contributor Author

I synchronized the changes to numericals/src. I changed return type of arg-* to (signed-byte 64) but that seems to hit a peltadot error. About <type> in return type, I didn't find it to cause any issue so far (not sure if it propagates correctly, but that's supposedly peltadot's responsibility as well).

@digikar99
Copy link
Owner

About in return type

Just rechecked. Type parameters like <type> in a pflet inside the body of a polymorph or in the return type of a polymorph pose no problems as long as there is a preceding <type> parameter as part of a orthogonally specializing type in the type list of the polymorph. If there's no <type> as part of a orthogonally specializing type in the type list of the polymorph or if it's a stray <type>, then that can pose a problem.

@digikar99 digikar99 merged commit 1c236fc into digikar99:master Feb 1, 2025
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants