Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use SIMD backend in normalize-arguments/* if possible #11

Merged
merged 1 commit into from
Dec 28, 2024

Conversation

kchanqvq
Copy link
Contributor

This mostly addresses the issue discussed in digikar99/dense-arrays#7 by avoiding calling asarray in code expecting high performance.

@digikar99
Copy link
Owner

Instead of (defun convert-argument-type (array-like out-type) ...), I'm leaning towards (defun ensure-array-with-type (array-like type) ...).

But otherwise this looks good!

@kchanqvq kchanqvq force-pushed the optimize-normalize-arguments branch from 7cb1fbc to 5b78429 Compare December 26, 2024 16:46
@digikar99
Copy link
Owner

Some more suggestions:

  1. Make the equivalent changes in src/basic-math/n-arg-fn.lisp
  2. Ensure that running make-dense-numericals.sh in project root produces the dense-numericals-src with appropriate code, particularly the above.
  3. The commit(s) should be tagged as [perf] ... or [int] ... rather than [add] ... since this is a performance enhancement or an internal change rather than a user-facing feature addition.

@kchanqvq kchanqvq force-pushed the optimize-normalize-arguments branch from 5b78429 to e219070 Compare December 28, 2024 06:01
@digikar99 digikar99 merged commit e4d8995 into digikar99:master Dec 28, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants