Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add createdBy field for all records #142

Merged
merged 3 commits into from
Sep 13, 2023
Merged

feat: add createdBy field for all records #142

merged 3 commits into from
Sep 13, 2023

Conversation

achou11
Copy link
Member

@achou11 achou11 commented Sep 12, 2023

Towards #83 , digidem/comapeo-core#153

Adds the createdBy field to the common definition, which is stored as bytes in protobuf and represented as a hex string in JSON. Pretty sure the descriptions are inaccurate so expecting to fix those based on feedback

Copy link
Member

@gmaclennan gmaclennan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a suggestion for the description, but otherwise good to go.

schema/common/v1.json Outdated Show resolved Hide resolved
@achou11 achou11 merged commit f1d4789 into main Sep 13, 2023
6 checks passed
@achou11 achou11 deleted the ac/created-by branch September 13, 2023 16:20
@achou11 achou11 mentioned this pull request Sep 13, 2023
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants