Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove unused properties from CoreManager #848

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: remove unused properties from CoreManager #848

wants to merge 1 commit into from

Conversation

EvanHahn
Copy link
Contributor

CoreManager was storing two properties, #projectKey and #state, which were never used. This removes them.

@EvanHahn
chore: remove unused properties from CoreManager
efdbe22 
CoreManager was storing two properties, `#projectKey` and `#state`,
which were never used. This removes them.
gmaclennan
gmaclennan requested changes Sep 19, 2024
View reviewed changes
Copy link
Member

@gmaclennan gmaclennan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this is the right fix for this, this is kind of a reminder that we should actually be using these properties to stop use of this class when it is closing or closed, and to stop errors when trying to close a second time while it is closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmaclennan gmaclennan gmaclennan requested changes

@tomasciccola tomasciccola Awaiting requested review from tomasciccola

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EvanHahn @gmaclennan