Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Note the default Ktlint style sections in docs #2092

Merged

Conversation

Goooler
Copy link
Contributor

@Goooler Goooler commented Apr 8, 2024

Closes #2090.

Copy link

@Jaehwa-Noh Jaehwa-Noh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you decide add instruction in README rather than change default value from #2090
I recommend add the real example code, not boilerplate code.
You know, actually "ktlint_code_style" to "intellij_idea" do nothing override, aren't you?

What do you think about my suggestion?

plugin-gradle/README.md Show resolved Hide resolved
plugin-gradle/README.md Show resolved Hide resolved
plugin-maven/README.md Show resolved Hide resolved
plugin-maven/README.md Show resolved Hide resolved
@Goooler
Copy link
Contributor Author

Goooler commented Apr 9, 2024

I wrote intellij_idea there cause it's an optional flag.

@nedtwigg nedtwigg merged commit 9cfe1ec into diffplug:main May 23, 2024
14 checks passed
@Goooler Goooler deleted the update-sections-about-ktlint-default-style branch May 24, 2024 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants