DFCC instrumentation: skip unused functions#8628
Merged
tautschnig merged 2 commits intodiffblue:developfrom Apr 28, 2025
Merged
DFCC instrumentation: skip unused functions#8628tautschnig merged 2 commits intodiffblue:developfrom
tautschnig merged 2 commits intodiffblue:developfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #8628 +/- ##
===========================================
- Coverage 80.37% 80.37% -0.01%
===========================================
Files 1686 1686
Lines 206872 206885 +13
Branches 73 73
===========================================
+ Hits 166268 166276 +8
- Misses 40604 40609 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
remi-delmas-3000
requested changes
Apr 16, 2025
remi-delmas-3000
approved these changes
Apr 28, 2025
Do not attempt to instrument functions that will never be used anyway. As we eventually use `remove_unused_functions` there is no point in trying to instrument them, and there is a scenario where the function may not have been compiled (see included test).
When we didn't instrument a function we should make sure that function truly never gets called.
087593a to
0c5644b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not attempt to instrument functions that will never be used anyway. As we eventually use
remove_unused_functionsthere is no point in trying to instrument them, and there is a scenario where the function may not have been compiled (see included test).