Skip to content

DFCC instrumentation: skip unused functions #8628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

tautschnig
Copy link
Collaborator

Do not attempt to instrument functions that will never be used anyway. As we eventually use remove_unused_functions there is no point in trying to instrument them, and there is a scenario where the function may not have been compiled (see included test).

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

Copy link

codecov bot commented Apr 16, 2025

Codecov Report

Attention: Patch coverage is 92.30769% with 1 line in your changes missing coverage. Please review.

Project coverage is 80.37%. Comparing base (9db5b1a) to head (0c5644b).
Report is 3 commits behind head on develop.

Files with missing lines Patch % Lines
.../goto-instrument/contracts/dynamic-frames/dfcc.cpp 92.30% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8628      +/-   ##
===========================================
- Coverage    80.37%   80.37%   -0.01%     
===========================================
  Files         1686     1686              
  Lines       206872   206885      +13     
  Branches        73       73              
===========================================
+ Hits        166268   166276       +8     
- Misses       40604    40609       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Do not attempt to instrument functions that will never be used anyway.
As we eventually use `remove_unused_functions` there is no point in
trying to instrument them, and there is a scenario where the function
may not have been compiled (see included test).
When we didn't instrument a function we should make sure that function
truly never gets called.
@tautschnig tautschnig force-pushed the do-not-instrument-unused-functions branch from 087593a to 0c5644b Compare April 28, 2025 17:29
@tautschnig tautschnig merged commit 7909d15 into diffblue:develop Apr 28, 2025
40 checks passed
@tautschnig tautschnig deleted the do-not-instrument-unused-functions branch April 28, 2025 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants