patch: force render standard fonts

[mrjeanp]

This is a follow up fix to my issue #2818

Problem:
When styling <Text/> with standard fontFamily such font doesn't render and instead it falls back to Helvetica which is the currently configured default font.

Fix:
I copied the following code and included a condition inside pickFontFromFontStack to force selecting the font that the user actually picked.

var standard = ['Courier', 'Courier-Bold', 'Courier-Oblique', 'Courier-BoldOblique', 'Helvetica', 'Helvetica-Bold', 'Helvetica-Oblique', 'Helvetica-BoldOblique', 'Times-Roman', 'Times-Bold', 'Times-Italic', 'Times-BoldItalic'];

Please review @diegomura 🙏

[changeset-bot]

⚠️ No Changeset found

Latest commit: a31f8f6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[theskillwithin]

Will this also fix custom fonts loaded via Font.register?

[mrjeanp]

@theskillwithin i never experienced issues with Font.register so i never attempted to fix it, this will most likely not fix your issue. Out of curiosity, what is your setup?

[theskillwithin]

@theskillwithin i never experienced issues with Font.register so i never attempted to fix it, this will most likely not fix your issue. Out of curiosity, what is your setup?

@mrjeanp For some reason the Font.register only works with external fonts. (I am using the words internal and external here to mean local path or external url path)

as soon as i try to use an internal font path by module loading or pointing to relative path /fonts/foo.ttf it does not work

oddly if I point to the same font like: https://mysite.com/fonts/foo.ttf this does work

using Remix (loaded via vite)

[mrjeanp]

Taken from https://react-pdf.org/fonts#register

Try using an absolute path, maybe use something like path.join(__dirname, '../fonts/foo.ttf')