Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove unnecessary check for response.buffer #2520

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wojtekmaj
Copy link
Contributor

If TypeScript is to be believed, cross-fetch's Response never returns buffer, so this check is unnecessary.

Copy link

changeset-bot bot commented Jan 18, 2024

🦋 Changeset detected

Latest commit: 660265a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@react-pdf/image Patch
@react-pdf/layout Patch
@react-pdf/renderer Patch
@react-pdf/examples Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

If TypeScript is to be believed, cross-fetch's Response never returns buffer, so this check is unnecessary.
Copy link
Owner

@diegomura diegomura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but not sure how can I be sure 😄

@wojtekmaj
Copy link
Contributor Author

Will provide more technical details when I find some free time.

In the meantime, let's keep it open, especially since I now realized that the check below my change is also redundant if TypeScript was indeed right :D

There are more exciting changes though :) I hope I didn't overwhelm you in the last couple of days!

@diegomura
Copy link
Owner

Not at all @wojtekmaj ! I'm thrilled you are contributing so much. Thanks for all the work man.

I hope I don't become a big pita with my TS scepticism 😄 I'm open to discussing but to be honest I don't feel very excited about switching to it. Mostly commenting it so you don't lose a lot of time migrating before discussing it :)

@wojtekmaj
Copy link
Contributor Author

I absolutely get you, especially since I hesitated for YEARS before I convinced myself to try TypeScript out.

I respect your decisions and trust your intuition when it comes to react-pdf maintenance. It's your project after all, and I have no right to make it feel any less yours.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants