Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix backward compatibility for usePDF hook #2334

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix backward compatibility for usePDF hook #2334

wants to merge 2 commits into from

Conversation

jeetiss
Copy link
Collaborator

@jeetiss jeetiss commented Jun 15, 2023

fix #2333

@changeset-bot
Copy link

changeset-bot bot commented Jun 15, 2023

⚠️ No Changeset found

Latest commit: 4ac19e7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@jeetiss jeetiss mentioned this pull request Jun 15, 2023
Open
@jjoselv
Copy link

jjoselv commented Aug 3, 2023 •
edited
Loading

Please merge this MR so we fix backwards compatibility

Also, in documentation:

image

Also the type of usePDF still requires one parameter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

usePDF hook incompatibility on 3.1.12 release
2 participants
@jeetiss @jjoselv